Load the host modules when the registry reads ats.py by path without the repo root on sys.path
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
7f04c10e9e
commit
4fb06191cf
4 files changed
+38
-7
No files matched your search
+1
-1
@@ -651,7 +651,7 @@ AFFINITY = range(-1, 3)
|
||||
#: read as when a role was posted, checked against live boards on
|
||||
#: 2026-09-29:
|
||||
#:
|
||||
#: - `greenhouse`: `plugins.ats._parse_greenhouse` already prefers
|
||||
#: - `greenhouse`: `plugins.atshosts.greenhouse.parse` already prefers
|
||||
#: `first_published` over `updated_at`. A live board (adyen) showed a job
|
||||
#: with `first_published` five months before `updated_at`, proving the
|
||||
#: first stays fixed while the second moves on an edit — the resettable
|
||||
|
||||
+7
-5
@@ -1,8 +1,10 @@
|
||||
"""Drop-in plugins, discovered by `plugin_paths` in `config.yaml`.
|
||||
|
||||
A plugin file imports `desk` only — see `tests/test_architecture.py`. This
|
||||
`__init__.py` makes the directory importable as `plugins.<name>` for the rest
|
||||
of roledesk (`jobs/pull.py`, `cli.py`, the tests), which the plugin contract
|
||||
itself never relies on: `desk.sources.registry` finds `ats.py` by path, not
|
||||
by this package.
|
||||
A plugin file imports `desk` only — see `tests/test_architecture.py` — and
|
||||
its own helpers in this directory. This `__init__.py` makes the directory
|
||||
importable as `plugins.<name>`, for the rest of roledesk (`jobs/pull.py`,
|
||||
`cli.py`, the tests) and for `ats.py`, whose hosts are the modules of the
|
||||
package `plugins/atshosts/`. `desk.sources.registry` still finds `ats.py` by
|
||||
path, not by this package; `ats.py` puts the repo root on `sys.path` itself
|
||||
when the app has not, so that `plugins.atshosts` imports either way.
|
||||
"""
|
||||
+12
-1
@@ -33,10 +33,12 @@ import ipaddress
|
||||
import json
|
||||
import logging
|
||||
import re
|
||||
import sys
|
||||
import time
|
||||
from collections.abc import Callable, Iterator, MutableMapping
|
||||
from datetime import UTC, datetime, timedelta
|
||||
from typing import Any
|
||||
from pathlib import Path
|
||||
from urllib.parse import unquote
|
||||
|
||||
import httpx
|
||||
@@ -46,7 +48,16 @@ from desk.sources import (
|
||||
SummaryPolicy, TaggingPolicy, TargetSpec, Tasks, USER_AGENT,
|
||||
)
|
||||
|
||||
from plugins import atshosts
|
||||
try:
|
||||
from plugins import atshosts
|
||||
except ModuleNotFoundError:
|
||||
# `desk.sources.registry` loads this file by its path, under a name of its
|
||||
# own, and the app puts the repo root on `sys.path` before it does; a
|
||||
# registry run without the app (a script, another working directory)
|
||||
# does not, and the host modules are found as the package beside this
|
||||
# file. So the root goes on the path then, and only then.
|
||||
sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
|
||||
from plugins import atshosts
|
||||
from plugins.atshosts._shared import Get, Row
|
||||
|
||||
# The names the parsers had here before they moved to their host modules,
|
||||
|
||||
@@ -6,6 +6,8 @@ a fake host stands in where a behaviour belongs to no real host yet."""
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import os
|
||||
import subprocess
|
||||
import sys
|
||||
import types
|
||||
from collections.abc import Callable
|
||||
@@ -63,6 +65,22 @@ def parse(body, slug): return []
|
||||
"""
|
||||
|
||||
|
||||
def test_the_registry_loads_ats_by_path_without_the_repo_root_on_the_path(
|
||||
tmp_path: Path) -> None:
|
||||
"""As `desk.sources.registry` does in a process the app did not set up:
|
||||
another working directory, and `plugins` not importable at first."""
|
||||
code = (
|
||||
"import importlib.util, sys\n"
|
||||
"assert importlib.util.find_spec('plugins') is None, 'plugins is importable'\n"
|
||||
"from desk.sources import registry\n"
|
||||
f"print(sorted(registry.available([{str(ROOT / 'plugins')!r}])))\n")
|
||||
env = {k: v for k, v in os.environ.items() if k != "PYTHONPATH"}
|
||||
done = subprocess.run([sys.executable, "-c", code], cwd=tmp_path, env=env,
|
||||
capture_output=True, text=True, timeout=60, check=False)
|
||||
assert done.returncode == 0, done.stderr
|
||||
assert "'ats'" in done.stdout and "'search'" in done.stdout
|
||||
|
||||
|
||||
def test_the_registry_loads_a_package_by_name_and_skips_private_modules(
|
||||
tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
path = _package(tmp_path, monkeypatch, "hostsok", {
|
||||
|
||||
Reference in new issue
Block a user