"""The tabs and the JSON API they call, against a temp database and FastAPI's TestClient. No network — nothing here touches an ATS host or the queue's own worker beyond starting and stopping it with the app.""" from __future__ import annotations from collections.abc import Iterator from datetime import UTC, datetime, timedelta from pathlib import Path from typing import Any import pytest from fastapi import FastAPI from fastapi.testclient import TestClient from app.config import Config, ServerConfig from app.main import create_app from app.storage import Store from app.web import MOVED, SETTINGS, TABS from auth import AuthConfig from desk.models import Item class Clock: """A controllable `Store.clock`, for tests that need upserts to land at distinct, known moments — see `test_storage.py`'s twin of this.""" def __init__(self) -> None: self.at = datetime(2026, 9, 23, 9, 0, tzinfo=UTC) def __call__(self) -> datetime: return self.at def tick(self, hours: float = 1) -> None: self.at += timedelta(hours=hours) def posting(source_id: str = "1", **raw: object) -> Item: item = Item(source_id=source_id, location=f"https://boards.example/acme/{source_id}", title="Senior Backend Engineer", body="Build things.", published_at=datetime(2026, 9, 20, tzinfo=UTC), raw=dict(raw)) item.source = "ats" return item @pytest.fixture def app(tmp_path: Path) -> FastAPI: """The database in `tmp_path` and the config passed in, so a test never touches `roledesk.db` and two tests never share a jobs table.""" return create_app(Config(server=ServerConfig(host="127.0.0.1", port=0), database=tmp_path / "roledesk.db")) @pytest.fixture def store(app: FastAPI) -> Store: return app.state.store @pytest.fixture def queue(app: FastAPI) -> Any: return app.state.queue @pytest.fixture def client(app: FastAPI) -> Iterator[TestClient]: with TestClient(app) as c: yield c # ------------------------------------------------------------------- roles def test_list_roles_filters_by_query_place_and_function( client: TestClient, store: Store) -> None: store.upsert_role(posting("1", company="Acme", place="Berlin", function="engineering")) store.upsert_role(posting("2", company="Acme", place="Munich", function="sales")) store.upsert_role(posting("3", company="Other", place="Berlin", function="engineering")) res = client.get("/api/roles", params={"q": "engineer", "place": "Berlin"}) assert res.status_code == 200 assert {r["source_id"] for r in res.json()["items"]} == {"1", "3"} res = client.get("/api/roles", params={"function": "sales"}) assert [r["source_id"] for r in res.json()["items"]] == ["2"] res = client.get("/api/roles", params={"company": "other"}) assert [r["source_id"] for r in res.json()["items"]] == ["3"] def test_list_roles_limit_is_bounded(client: TestClient, store: Store) -> None: for i in range(3): store.upsert_role(posting(str(i))) assert len(client.get("/api/roles", params={"limit": 1}).json()["items"]) == 1 assert client.get("/api/roles", params={"limit": 0}).status_code == 422 assert client.get("/api/roles", params={"limit": 1001}).status_code == 422 def test_muted_roles_are_hidden_unless_show_muted(client: TestClient, store: Store) -> None: store.add_company("Acme", key="acme") store.upsert_role(posting("1", company="Acme")) store.upsert_role(posting("2", company="Other")) agent = store.save_agent("A") other = store.save_agent("B") def shown(**params: Any) -> set[str]: return {r["source_id"] for r in client.get("/api/roles", params=params).json()["items"]} assert shown() == {"1", "2"} # No agent in the body: the default agent's, which is also who a list # without `agent` hides for. assert client.post("/api/companies/acme/affinity", json={"affinity": -1}).status_code == 200 assert shown() == {"2"} assert shown(show_muted="true") == {"1", "2"} assert shown(agent=agent.id, order="newest") == {"2"} # Hidden is per agent: the other agent still sees Acme. assert shown(agent=other.id, order="newest") == {"1", "2"} assert [c["affinity"] for c in client.get("/api/companies").json()] == [-1] assert [c["affinity"] for c in client.get("/api/companies", params={"agent": other.id}).json()] == [0] def test_muted_is_excluded_before_the_limit_not_after( client: TestClient, store: Store) -> None: """A regression case: filtering a muted company out of an already `LIMIT`-ed page can leave nothing to show, if that company happens to be the newest thing in the database — exactly what a company with hundreds of roles, all freshly (re-)pulled at once, produces.""" clock = Clock() store.clock = clock store.add_company("Acme", key="acme") store.set_affinity(store.save_agent("A").id, "acme", -1) store.upsert_role(posting("other", company="Other")) clock.tick() for i in range(3): store.upsert_role(posting(f"a{i}", company="Acme")) clock.tick() res = client.get("/api/roles", params={"limit": 1}) assert [r["source_id"] for r in res.json()["items"]] == ["other"] assert res.json()["total"] == 1 def test_list_roles_pages_by_offset_and_counts_the_total( client: TestClient, store: Store) -> None: clock = Clock() store.clock = clock for i in range(5): store.upsert_role(posting(str(i))) clock.tick() first = client.get("/api/roles", params={"limit": 2}).json() assert [r["source_id"] for r in first["items"]] == ["4", "3"] assert first["total"] == 5 rest = client.get("/api/roles", params={"limit": 2, "offset": 4}).json() assert [r["source_id"] for r in rest["items"]] == ["0"] and rest["total"] == 5 assert client.get("/api/roles", params={"offset": 9}).json() == {"items": [], "total": 5} assert client.get("/api/roles", params={"offset": -1}).status_code == 422 assert len(client.get("/api/roles").json()["items"]) == 5 # default 60 def test_a_vote_is_set_cleared_and_filtered_on(client: TestClient, store: Store) -> None: for sid in ("liked", "passed", "fine", "open"): store.upsert_role(posting(sid)) uid = {r.source_id: r.uid for r in store.roles()} agent = store.save_agent("A") # No `agent` in the body: the default agent's vote. res = client.post(f"/api/roles/{uid['liked']}/vote", json={"value": 1}) assert res.status_code == 200 assert res.json()["vote"] == 1 and res.json()["voted_at"] is not None assert store.votes(agent.id) == {uid["liked"]: 1} client.post(f"/api/roles/{uid['passed']}/vote", json={"value": -1, "agent": agent.id}) client.post(f"/api/roles/{uid['fine']}/vote", json={"value": 0}) def judged(value: str, **params: Any) -> set[str]: page = client.get("/api/roles", params={"judged": value, **params}).json() return {r["source_id"] for r in page["items"]} assert judged("liked") == {"liked"} assert judged("passed") == {"passed"} assert judged("unjudged") == {"open"} assert judged("") == {"liked", "passed", "fine", "open"} # a pass is not hidden assert judged("liked", agent=agent.id, order="newest") == {"liked"} assert client.get("/api/roles", params={"judged": "maybe"}).status_code == 422 assert client.get(f"/api/roles/{uid['liked']}").json()["vote"] == 1 assert client.get(f"/api/roles/{uid['liked']}", params={"agent": agent.id}).json()["vote"] == 1 cleared = client.delete(f"/api/roles/{uid['liked']}/vote") assert cleared.status_code == 200 assert cleared.json()["vote"] is None and cleared.json()["voted_at"] is None assert judged("unjudged") == {"open", "liked"} cleared = client.delete(f"/api/roles/{uid['passed']}/vote", params={"agent": agent.id}) assert cleared.status_code == 200 and cleared.json()["vote"] is None assert client.post(f"/api/roles/{uid['open']}/vote", json={"value": 2}).status_code == 422 assert client.post("/api/roles/nope/vote", json={"value": 1}).status_code == 404 assert client.delete("/api/roles/nope/vote").status_code == 404 assert client.post(f"/api/roles/{uid['open']}/vote", json={"value": 1, "agent": 999}).status_code == 404 assert client.delete(f"/api/roles/{uid['open']}/vote", params={"agent": 999}).status_code == 404 def test_votes_are_per_agent_over_the_api(client: TestClient, store: Store) -> None: store.upsert_role(posting("1")) uid = posting("1").uid one = store.save_agent("One") two = store.save_agent("Two") assert client.post(f"/api/roles/{uid}/vote", json={"value": 1, "agent": one.id}).json()["vote"] == 1 assert client.post(f"/api/roles/{uid}/vote", json={"value": -1, "agent": two.id}).json()["vote"] == -1 assert client.get(f"/api/roles/{uid}", params={"agent": one.id}).json()["vote"] == 1 assert client.get(f"/api/roles/{uid}", params={"agent": two.id}).json()["vote"] == -1 assert client.get(f"/api/roles/{uid}").json()["vote"] == 1 # the default's assert client.get(f"/api/roles/{uid}", params={"agent": 999}).status_code == 404 def listed(**params: Any) -> list[int | None]: return [r["vote"] for r in client.get("/api/roles", params=params).json()["items"]] assert listed(agent=one.id, order="newest") == [1] assert listed(agent=two.id, order="newest") == [-1] assert listed() == [1] def test_a_vote_or_an_affinity_needs_an_agent_to_belong_to( client: TestClient, store: Store) -> None: """Nothing to vote as: a 422 with a sentence, not a vote that lands nowhere. Reading is fine, everything is simply unjudged and neutral.""" store.upsert_role(posting("1")) store.add_company("Acme", key="acme") uid = posting("1").uid res = client.post(f"/api/roles/{uid}/vote", json={"value": 1}) assert res.status_code == 422 and "Settings" in res.json()["detail"] assert client.delete(f"/api/roles/{uid}/vote").status_code == 422 assert client.post("/api/companies/acme/affinity", json={"affinity": 1}).status_code == 422 assert client.get(f"/api/roles/{uid}").json()["vote"] is None assert client.get("/api/roles").json()["items"][0]["vote"] is None assert client.get("/api/companies").json()[0]["affinity"] == 0 def test_roles_with_an_agent_can_be_ordered_newest_and_keep_the_votes( client: TestClient, store: Store) -> None: clock = Clock() store.clock = clock for sid in ("1", "2", "3"): store.upsert_role(posting(sid)) clock.tick() uid = {r.source_id: r.uid for r in store.roles()} agent = store.save_agent("A") store.replace_scores(agent.id, [(uid["1"], 0.9, ""), (uid["2"], 0.1, "")]) # 3 unscored store.set_vote(agent.id, uid["1"], 1) page = client.get("/api/roles", params={"agent": agent.id, "order": "newest"}).json() assert [r["source_id"] for r in page["items"]] == ["3", "2", "1"] assert [r["score"] for r in page["items"]] == [None, None, None] assert [r["vote"] for r in page["items"]] == [None, None, 1] assert page["total"] == 3 scored = client.get("/api/roles", params={"agent": agent.id, "order": "score"}).json() assert [r["source_id"] for r in scored["items"]] == ["1", "2"] assert client.get("/api/roles", params={"agent": agent.id, "order": "best"}).status_code == 422 def test_a_vote_moves_a_role_in_the_ranking_at_once( client: TestClient, store: Store) -> None: for sid in ("a", "b", "c"): store.upsert_role(posting(sid)) uid = {r.source_id: r.uid for r in store.roles()} agent = store.save_agent("A") store.replace_scores(agent.id, [(uid["a"], 0.9, ""), (uid["b"], 0.6, ""), (uid["c"], 0.55, "")]) def ranked() -> list[tuple[str, float]]: page = client.get("/api/roles", params={"agent": agent.id}).json() return [(r["source_id"], round(r["score"], 3)) for r in page["items"]] assert ranked() == [("a", 0.9), ("b", 0.6), ("c", 0.55)] client.post(f"/api/roles/{uid['a']}/vote", json={"value": -1}) client.post(f"/api/roles/{uid['c']}/vote", json={"value": 1}) assert ranked() == [("c", 0.66), ("b", 0.6), ("a", 0.45)] client.post(f"/api/roles/{uid['b']}/vote", json={"value": 0}) client.post(f"/api/roles/{uid['a']}/vote", json={"value": 1}) assert ranked() == [("a", 1.0), ("c", 0.66), ("b", 0.6)] # capped at 1 def test_read_state_is_set_and_cleared_over_the_api(client: TestClient, store: Store) -> None: store.upsert_role(posting("1")) uid = posting("1").uid res = client.post(f"/api/roles/{uid}/read") assert res.status_code == 200 assert res.json()["read_at"] is not None res = client.delete(f"/api/roles/{uid}/read") assert res.status_code == 200 assert res.json()["read_at"] is None assert client.post("/api/roles/nope/read").status_code == 404 assert client.delete("/api/roles/nope/read").status_code == 404 def test_list_roles_filters_by_include_read(client: TestClient, store: Store) -> None: store.upsert_role(posting("1")) store.upsert_role(posting("2")) uid = posting("1").uid client.post(f"/api/roles/{uid}/read") all_ = client.get("/api/roles").json() assert {r["source_id"] for r in all_["items"]} == {"1", "2"} unread = client.get("/api/roles", params={"include_read": "false"}).json() assert {r["source_id"] for r in unread["items"]} == {"2"} assert unread["total"] == 1 def test_list_roles_filters_by_tags_any_and_all(client: TestClient, store: Store) -> None: store.upsert_role(posting("1")) store.upsert_role(posting("2")) uid = {r.source_id: r.uid for r in store.roles()} store.set_tags(uid["1"], ["python", "backend"]) store.set_tags(uid["2"], ["python", "frontend"]) res = client.get("/api/roles", params={"tags": ["python"]}) assert {r["source_id"] for r in res.json()["items"]} == {"1", "2"} both = client.get("/api/roles", params={"tags": ["python", "backend"], "tag_mode": "all"}) assert {r["source_id"] for r in both.json()["items"]} == {"1"} [item] = both.json()["items"] assert item["tags"] == ["backend", "python"] def test_filters_lists_tag_counts_and_respects_show_muted( client: TestClient, store: Store) -> None: store.add_company("Hidden", key="hidden") agent = store.save_agent("A") # the default agent, whose hidden companies count store.set_affinity(agent.id, "hidden", -1) store.upsert_role(posting("1", company="Acme")) store.upsert_role(posting("2", company="Hidden")) uid = {r.source_id: r.uid for r in store.roles(hide_muted=False)} store.set_tags(uid["1"], ["python"]) store.set_tags(uid["2"], ["python"]) res = client.get("/api/filters") assert res.status_code == 200 assert res.json() == {"tags": [{"tag": "python", "count": 1, "unread": 1}]} muted = client.get("/api/filters", params={"show_muted": "true"}) assert muted.json() == {"tags": [{"tag": "python", "count": 2, "unread": 2}]} def test_one_role_and_its_read_page(client: TestClient, store: Store) -> None: store.upsert_role(posting("1", company="Acme", place="Berlin")) uid = posting("1").uid res = client.get(f"/api/roles/{uid}") assert res.status_code == 200 body = res.json() assert (body["uid"], body["company"], body["description"]) == (uid, "Acme", "Build things.") assert body["vote"] is None and body["summary"] == "" and body["article_text"] == "" assert client.get("/api/roles/nope").status_code == 404 page = client.get(f"/roles/{uid}") assert page.status_code == 200 assert '' in page.text and "/static/roles.js" in page.text missing = client.get("/roles/nope") assert missing.status_code == 404 and "text/html" in missing.headers["content-type"] def test_the_roles_page_offers_the_judged_filter_and_hidden_companies( client: TestClient) -> None: page = client.get("/").text assert 'id="f-judged"' in page and "