Record the review's decisions in decisions.md and rewrite open.md as what is left: the points for the owner, what the ADRs do not say, and the structure of the plugin layer
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
1 parent
e8157d9509
commit
e61185e4b9
2 files changed
+86
-47
No files matched your search
+13
-3
@@ -16,7 +16,7 @@ What was decided for roledesk and the reason for each. The target design is the
|
||||
|
||||
**A group is rows that all match each other, never a chain.** A row with no place matches Belgium and the Netherlands, and joining on one match merged both on the live data. Rows are taken sharpest first (a town, then only a country, then neither) and join a group only when they match every member.
|
||||
|
||||
**One posting per place is folded too, on every host.** A host that lists one job once per office gives rows of the same company and title whose towns never meet; `dupes.fold` merges those of one host when their texts share at least `SAME_TEXT` (30%) of their words, and the kept role keeps each copy's place and link. It applies to every host, not only to readers that declare `places="copies"`, because most such rows came from hosts that do not declare it.
|
||||
**One posting per place is folded too, on every host.** A host that lists one job once per office gives rows of the same company and title whose towns never meet; `dupes.fold` merges those of one host when their texts share at least `SAME_TEXT` (30%) of their words, and the kept role keeps each copy's place and link. It applies to every host, not only to readers that declare `places="copies"`, because most such rows came from hosts that do not declare it. A remote listing and an office listing stay two roles: the kept role takes a copy's places and not its remote, and the fetch gate reads a remote role by its area, so a remote listing folded behind an office elsewhere was rejected with it, and an office listing behind a remote role elsewhere likewise.
|
||||
|
||||
**A copy is stored as `roles.dup_of` and rebuilt from scratch after every pull.** Every reader of open roles adds `dup_of IS NULL`, which keeps `idx_roles_posted` usable where a window function over the filtered rows would scan them all. Where a group changed, the kept role takes the earliest `read_at` and each agent's latest vote from its copies; an unchanged group is left alone, so marking a role unread again sticks. The per-board counts on Sources still count copies, since they report what a board holds.
|
||||
|
||||
@@ -66,6 +66,10 @@ What was decided for roledesk and the reason for each. The target design is the
|
||||
|
||||
**Jobindex ads are read from the feed, and a posting is fetched only on demand.** Following each item's link would count as a click in Jobindex's statistics and cost a request per role, so the pull never follows it, and discovering a company's board from a search result is left for later. `POST /api/roles/{uid}/text` (`app/jobs/posting.py`) follows the "Se jobbet" link for a role somebody opened, since one click for a posting somebody opened is fair, and keeps it as `roles.posting_url`, which the reader's link-out then prefers.
|
||||
|
||||
**A search's read never closes by its list** (ADR Fetch prep and score 1.3). A search that read as many results as its provider stated used to close every role its query no longer returned, liked and saved ones included, although a result list is never a company's whole list. Search roles close by age alone.
|
||||
|
||||
**A read that stalls is incomplete, and a sweep's cursor may be a pair.** A reader that sees the host send a page again hands it over empty with a cursor, and the runner ends the read incomplete; a cursor of None there read as the last page, and on a host that states no total as a complete read that closed what the pages had not listed. With a stated total a page of ids already read is not a stall, since a resumed sweep starts on one when the list grew at the top. A cursor is kept across pulls when it survives JSON apart from a tuple coming back as a list, so Workday's and SuccessFactors' sweeps resume.
|
||||
|
||||
**Switching a board or search off closes its open roles.** Only a pull that reads a target closes its roles, so a target no longer read would keep them open for good. Switched back on, the next pull reopens what it still lists. A batch in flight when the switch happens reopens them, so the settle closes every switched-off target once more.
|
||||
|
||||
**A destructive switch asks first; a reopening one queues a pull.** Switching a board or search off, replacing a board and detaching one each close roles in a tap, so the page asks first when there are roles to lose, naming the count. Switching a target on, following or setting a board, setting All locations or All roles on and saving a search each queue `pull` at once instead of waiting up to six hours for the schedule. The pull is queued in the API route, not in the page's script, so a script calling the endpoint gets what a click gets; `claim_run`'s refusal is not an error, since the run in flight or the next one reads the change.
|
||||
@@ -154,7 +158,7 @@ What was decided for roledesk and the reason for each. The target design is the
|
||||
|
||||
**desk's own summary and tagging are off.** Every profile declares `SummaryPolicy(enabled=False)` and `TaggingPolicy(enabled=False)`; roledesk's `extract` fills the gate columns and its `summarise` writes the summary and tags, as `ModelTask`s of its own.
|
||||
|
||||
**A gate rejects on evidence, not on absence, and the location lines are one group** (ADR Fetch prep and score 1.1). A gate used to reject a role whose column was empty, and extract, which fills that column, reads only the cut, so every role from a board that writes "Remote" or "Hybrid" as its location was out of reach for good. The location lines are `any` gates that form one group a role must match one of, so "in Denmark, or remote" is two `any` gates where `require` alone could only say "and".
|
||||
**A gate rejects on evidence, not on absence, and the location lines are one group** (ADR Fetch prep and score 1.1). A gate used to reject a role whose column was empty, and extract, which fills that column, reads only the cut, so every role from a board that writes "Remote" or "Hybrid" as its location was out of reach for good. The location lines are `any` gates that form one group a role must match one of, so "in Denmark, or remote" is two `any` gates where `require` alone could only say "and". Three cases count as an unknown location rather than as evidence. A place text the gazetteer cannot resolve is one: "Storkøbenhavn" and "Headquarters" were read as "not Malmö" and rejected about 650 open roles, most of them in Greater Copenhagen. A role whose country and place are both unknown passes whatever its remote says, since a board that writes only "Hybrid" may sit in one of the agent's towns. A place that holds the agent's places, Øresund or Europe for Denmark, is no evidence against either, but only when the role names no place elsewhere: `London; Europe` is in London. Such a role enters the cut on its level, extract reads it and the gate is applied again on what it found.
|
||||
|
||||
**A favourite only raises the level; the company switches do the widening** (ADR Fetch prep and score 2.1). Affinity used to skip gates, which made it both a widening and a ranking; widening now belongs to All locations and All roles, which are the same for every agent because fetching is shared.
|
||||
|
||||
@@ -162,6 +166,8 @@ What was decided for roledesk and the reason for each. The target design is the
|
||||
|
||||
**Role exclusion matches title phrases, not `function`.** Sales titles (Account Executive, Client Partner) and individual data engineering ranked high, since their postings read like the sales engineering and data leadership the prompts describe. `function = sales` could not remove them: the keyword classifier files "Solutions Engineer" and "pre-sales" under sales, so it would also have gated Field CTO, Staff Solutions Engineer and every AI Deployment Strategist near the agent's top. A value matches as whole words of `title_key`, so `data engineer` gates "Senior MLOps/Data Engineer" and not "Data Engineering Manager", and the reason names the value that matched ("title account executive"). Bare `sales` and `vice president` stay off the owner's list because they would take Sales Engineer and VP roles, and `account manager` because it would take Technical Account Manager.
|
||||
|
||||
**A role that gains text is extracted again.** Extract reads a role once, and a role read from its title alone (fetch text capped or failing, or the role entering the cut late) kept title-only place, remote and level for good. The pull that brings a better text now resets `extracted_at` beside dropping the vector, so both stages read the text.
|
||||
|
||||
**A role with no vector is scored without prompt closeness and job like.** Their weights leave the denominator, so a role `embed` has not reached ranks on newness and affinity instead of sinking to the bottom. It is gated as "no vector" only when `fit` is the only weighted term, and as "no prompt vector" when no prompt could be embedded.
|
||||
|
||||
**Each run replaces an agent's scores.** `replace_scores` deletes and inserts in one transaction, so a role closed or hidden since the last run drops out rather than keeping a stale score, and a reader sees one list or the other.
|
||||
@@ -188,7 +194,11 @@ What was decided for roledesk and the reason for each. The target design is the
|
||||
|
||||
**Each page renders a shell that its own script fills.** The server renders only select options, from `app.models`, `plugins.ats.FUNCTIONS` and `plugins.ats.HOSTS`, so they cannot drift from what the store and the plugin accept. One code path for "show this" beats a server-rendered first page plus a client re-render after every filter change.
|
||||
|
||||
**The feed loads whether or not its enhancements do.** `/api/agents` and `/api/companies` only draw the affinity control and pick the viewing agent's order, so the feed's own request goes out beside them rather than after, they redraw what they touch when they land, and a failed feed request shows a retry (`state.feedError`). Awaiting both first once left the feed blank for good behind a silent catch.
|
||||
**The feed's first request names the agent, and waits only when it cannot.** The server gates nothing for a request without an agent, so a first request sent before the agents were known listed every open role until they arrived, and for good when `/api/agents` failed. The request carries the agent of the address, else the one this browser viewed last; with neither it waits for the agents. Companies, tag counts and saved filters still fill in when they arrive and the feed does not wait on them, since awaiting them once left the feed blank behind a silent catch. When the agents cannot be had, the feed shows its error state with a retry (`state.feedError`).
|
||||
|
||||
**A page starts a row earlier for each vote or read since the last one.** The server sorts afresh on every request, and a pass, or a read with Show read off, takes a role out of the part already loaded, so the next page asked from the count of rows on screen skipped one role and showed another twice. The offset the server has read is kept apart from the rows on screen, the next page steps back one row per change and drops the rows already shown, and the end of the list is the server's to say. A rescore during scrolling can still shift the list; only a snapshot of the order on the server would rule that out.
|
||||
|
||||
**The rail's counts cover what the feed shows.** Tag, company and place counts ignored the fetch gate, so a chip promised more roles than the list held (Novo Nordisk 134 against 102). With an agent named, each count keeps to the roles that agent's gate passes.
|
||||
|
||||
**`company=` and `place=` on `/api/roles` match a case-insensitive substring of what the board wrote.** They are free text a person types, not a slug, so "Trade Republic" finds `trade-republic-bank` without knowing the key, and other pages link with them.
|
||||
|
||||
|
||||
Reference in new issue
Block a user