Merge the seniority range filter: From, To and Track in the rail (wp-sen-b-range)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
WolfandClaude Opus 5.5 committed 2026-09-30 13:14:45 +02:00
commit d529f6c0ce
6 files changed
+207 -71

No files matched your search

+69 -6
View File
@@ -16,6 +16,7 @@ from fastapi.testclient import TestClient
from app.config import Config, ServerConfig
from app.main import create_app
from app.models import LADDER, RUNGS
from app.models import excerpt as models_excerpt
from app.storage import Store
from app.web import SETTINGS, TABS
@@ -116,15 +117,57 @@ def test_list_roles_filters_by_company_keys_places_and_seniority(
assert shown(places=["country:DK", "region:skane"]) == {"kbh", "billund", "malmo"}
assert shown(places=["place:kobenhavn"]) == {"kbh"}
assert shown(places=["Lund"]) == set() # not Billund
assert shown(seniority=["senior"]) == {"kbh", "berlin", "malmo"}
assert shown(seniority=["senior"], seniority_unknown="false") == {"kbh", "berlin"}
assert shown(seniority=["senior", "junior"], seniority_unknown="false",
assert shown(level_from="senior", level_to="senior") == {"kbh", "berlin", "malmo"}
assert shown(level_from="senior", level_to="senior",
seniority_unknown="false") == {"kbh", "berlin"}
assert shown(level_from="junior", level_to="senior", seniority_unknown="false",
company_keys=["other"]) == {"billund", "berlin"}
res = client.get("/api/roles", params={"places": ["region:atlantis"]})
assert res.status_code == 422 and "region:atlantis" in res.json()["detail"]
res = client.get("/api/roles", params={"seniority": ["boss"]})
res = client.get("/api/roles", params={"level_from": "boss"})
assert res.status_code == 422 and "boss" in res.json()["detail"]
res = client.get("/api/roles", params={"level_to": "boss"})
assert res.status_code == 422 and "level_to" in res.json()["detail"]
res = client.get("/api/roles", params={"track": "both"})
assert res.status_code == 422 and "both" in res.json()["detail"]
# The repeated `seniority` of the chip row is not a parameter any more.
assert shown(seniority=["junior"]) == set(uid)
def test_list_roles_filters_by_a_range_of_rungs_and_a_track(
client: TestClient, store: Store) -> None:
for sid, title in (("junior", "Junior Engineer"), ("senior", "Senior Engineer"),
("staff", "Staff Engineer"), ("manager", "Engineering Manager"),
("director", "Director of Engineering"), ("none", "Engineer")):
item = posting(sid)
item.title = title
upsert(store, item)
uid = {r.source_id: r.uid for r in store.roles()}
def shown(**params: Any) -> set[str]:
res = client.get("/api/roles", params=params)
assert res.status_code == 200, res.text
found = {r["uid"] for r in res.json()["items"]}
return {sid for sid, u in uid.items() if u in found}
everyone = set(uid)
assert shown() == everyone
# A range: a bound alone is open on the other side; no level passes.
assert shown(level_from="staff") == {"staff", "manager", "director", "none"}
assert shown(level_to="senior") == {"junior", "senior", "none"}
assert shown(level_from="senior", level_to="staff",
seniority_unknown="false") == {"senior", "staff", "manager"}
# A track keeps its own side and the rungs under Staff, which have none.
assert shown(track="ic", seniority_unknown="false") == {"junior", "senior", "staff"}
assert shown(track="people", seniority_unknown="false") == {
"junior", "senior", "manager", "director"}
# Both together.
assert shown(level_from="staff", track="people",
seniority_unknown="false") == {"manager", "director"}
assert shown(level_from="staff", track="ic", seniority_unknown="false") == {"staff"}
# `seniority_unknown` alone changes nothing: no bound, no track, no filter.
assert shown(seniority_unknown="false") == everyone
def test_role_facets_count_each_facet_under_the_other_filters(
@@ -137,8 +180,8 @@ def test_role_facets_count_each_facet_under_the_other_filters(
upsert(store, item)
res = client.get("/api/roles/facets",
params={"seniority": ["senior"], "seniority_unknown": "false",
"pay": "stated"})
params={"level_from": "senior", "level_to": "senior",
"seniority_unknown": "false", "pay": "stated"})
assert res.status_code == 200
body = res.json()
levels = {f["value"]: f["count"] for f in body["seniority"]}
@@ -146,6 +189,12 @@ def test_role_facets_count_each_facet_under_the_other_filters(
assert body["pay"] == [{"value": "normalised", "count": 1}, # a and b are senior
{"value": "stated", "count": 0}, {"value": "", "count": 1}]
assert client.get("/api/roles/facets", params={"places": ["country:ZZ"]}).status_code == 422
assert client.get("/api/roles/facets", params={"track": "boss"}).status_code == 422
# A track counts the same levels; the facet leaves its own filter out.
res = client.get("/api/roles/facets", params={"track": "people"})
assert res.status_code == 200
assert {f["value"]: f["count"] for f in res.json()["seniority"]}["senior"] == 2
def test_suggest_companies_folds_the_name_and_leaves_out_the_hidden(
@@ -519,6 +568,20 @@ def test_the_roles_page_offers_the_judged_filter_and_hidden_companies(
assert "Show muted" not in page
def test_the_roles_page_carries_the_ladder_as_json(client: TestClient, store: Store) -> None:
upsert(store, posting("1"))
uid = posting("1").uid
for page in (client.get("/").text, client.get(f"/roles/{uid}").text):
marker = "window.ROLEDESK_LADDER = "
start = page.index(marker) + len(marker)
ladder = json.loads(page[start:page.index(";\n", start)])
assert ladder["rungs"] == list(RUNGS)
assert ladder["levels"] == {level: list(place) for level, place in LADDER.items()}
for name in ("f-level-from", "f-level-to", "f-track"):
assert f'id="{name}"' in page
assert 'id="f-seniority"' not in page
# --------------------------------------------------------------- companies
def test_companies_lists_board_and_open_role_count(