Let the runner drop and count a row without an id, a title or a link, as ADR Plugins 3.8 has it, in one place for whole, paged and search reads: the count is stamped per target, logged, named on the board's row, and over 10% of the rows fails the read; the 28 readers hand every listing over instead of skipping it

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
WolfandClaude Fable 5.1 committed 2026-10-06 14:04:33 +02:00
1 parent 38c31c830b
commit 911dfe8584
58 files changed
+479 -203

No files matched your search

+5 -4
View File
@@ -20,7 +20,7 @@ if str(ROOT) not in sys.path:
from app.jobs.discover import boards_in # noqa: E402
from plugins import ats # noqa: E402
from plugins.readers import oracle # noqa: E402
from plugins.readers import _runner, oracle # noqa: E402
from plugins.readers._shared import is_web_url # noqa: E402
FIXTURES = ROOT / "tests" / "fixtures" / "ats"
@@ -84,14 +84,15 @@ def test_a_department_is_taken_where_a_tenant_fills_one() -> None:
assert [r["department"] for r in rows[:3]] == ["Supply Chain", "Finance", ""]
def test_a_role_without_a_title_or_with_an_id_that_is_no_id_is_left_out() -> None:
def test_a_role_without_a_title_or_with_an_id_that_is_no_id_is_dropped_by_the_runner() -> None:
data = _listing()
roles = data["items"][0]["requisitionList"]
roles[0]["Title"] = " "
roles[1]["Id"] = "1/../../x"
roles[2]["Id"] = ""
assert [r["source_id"] for r in oracle.parse(json.dumps(data).encode(), SLUG)] == \
["40975", "31680"]
rows = oracle.parse(json.dumps(data).encode(), SLUG)
assert rows[1]["url"] == "" # the id builds no link
assert [r["source_id"] for r in rows if _runner.valid(r)] == ["40975", "31680"]
def test_a_listing_without_the_expand_has_no_roles() -> None: