diff --git a/app/static/companies.js b/app/static/companies.js index 4e85538..2c83ca7 100644 --- a/app/static/companies.js +++ b/app/static/companies.js @@ -420,9 +420,13 @@ const row = document.createElement("div"); row.className = "crow"; if (company.affinity === -1) row.dataset.hidden = "true"; + // By key, as the feed's own company links are, so the Roles page opens + // the company view with its strip and gate note. A name would be a + // substring there, which also lists other companies whose names hold it + // and misses roles spelt otherwise. const link = document.createElement("a"); link.className = "name"; - link.href = `/?company=${encodeURIComponent(company.name)}`; + link.href = `/?company_keys=${encodeURIComponent(company.key)}`; link.title = "This company's open roles"; link.textContent = company.name; row.appendChild(link); diff --git a/app/static/roles.js b/app/static/roles.js index 7b3b086..6153842 100644 --- a/app/static/roles.js +++ b/app/static/roles.js @@ -76,14 +76,14 @@ * screen with that company as its one company chip (`?company_keys=`); a * plain click filters in place and pushes. With one company filtered a strip * over the feed names it, counts its roles, links its careers page and - * carries its ⊘ ▲ ★ for the viewing agent. `?company=`, `?company_keys=` and - * `?agent=` are how the Companies and Search agents pages link in. + * carries its ⊘ ▲ ★ for the viewing agent. `?company_keys=` and `?agent=` + * are how Settings › Sources and Search agents link in. * * Company and Place in the rail are chip inputs (chips.js) on the suggest * routes: a chip is a company key or a place token (`country:DK`, * `region:skane`), several joined by OR. `?company=` and `?place=`, the - * substrings of the links from other pages, still filter and show as a chip - * of their own to take off; nothing in the rail types a new one. Seniority + * substrings of older links and saved filters, still filter and show as a + * chip of their own to take off; nothing in the rail types a new one. Seniority * (a From and a To rung and a Track, `level_from`, `level_to` and `track`) * and Pay carry the counts of `/api/roles/facets`, asked after each reload * with the feed's own parameters, so each says what a click would add. The @@ -156,10 +156,11 @@ // Everything `clearFilters` has to put back, in one place, so a new filter // added here cannot be forgotten there. `company` and `place` are the - // substrings of links from other pages; `companyKeys` and `places` are the - // rail's chips. `levelFrom`, `levelTo` and `track` are the seniority range; - // `seniorityUnknown` and `payUnknown` are the "and roles with no level / no - // pay" boxes, asked only while a range, a track or a pay option is picked. + // substrings of older links and saved filters; `companyKeys` and `places` + // are the rail's chips. `levelFrom`, `levelTo` and `track` are the seniority + // range; `seniorityUnknown` and `payUnknown` are the "and roles with no + // level / no pay" boxes, asked only while a range, a track or a pay option + // is picked. function blankFilter() { return { sort: "score", agent: null, period: "all", tags: new Set(), showRead: true, @@ -739,7 +740,7 @@ input.set(want); } - /* `?company=` or `?place=`, the substring a link from another page + /* `?company=` or `?place=`, the substring an older link or saved filter brought: a plain chip saying what it matches, which takes it off and pushes, as a filter does. */ function renderText(id, text, noun, key) { diff --git a/app/templates/roles.html b/app/templates/roles.html index abba27e..1ff451a 100644 --- a/app/templates/roles.html +++ b/app/templates/roles.html @@ -92,8 +92,9 @@