Add a Watchlist tab for the companies the app cannot read a board of
Rate each one Yes or No apart from affinity, open its careers page with the time noted, and set a missing or wrong link in the row. Migration 15 adds companies.watch and careers_opened_at. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
6f273cfdd6
commit
7dcb2c1705
11 files changed
+445
-12
No files matched your search
@@ -85,6 +85,17 @@ def test_a_role_address_is_the_same_page_with_its_reader_open(
|
||||
assert missing.status_code == 404 and "text/html" in missing.headers["content-type"]
|
||||
|
||||
|
||||
def test_the_watchlist_is_the_third_tab_and_a_shell(client: TestClient) -> None:
|
||||
page = client.get("/watchlist")
|
||||
assert page.status_code == 200
|
||||
assert 'href="/watchlist"\n class="active" aria-current="page">Watchlist' in page.text
|
||||
assert 'id="watchlist-list"' in page.text and "/static/watchlist.js" in page.text
|
||||
nav = page.text[page.text.index("<nav>"):page.text.index("</nav>")]
|
||||
tabs = [t for t in ("Roles", "Applications", "Watchlist") if f">{t}</a>" in nav]
|
||||
assert tabs == ["Roles", "Applications", "Watchlist"]
|
||||
assert nav.count('aria-current="page"') == 1
|
||||
|
||||
|
||||
def test_the_read_page_of_its_own_is_gone(client: TestClient) -> None:
|
||||
assert client.get("/static/role.js").status_code == 404
|
||||
other = client.get("/applications").text
|
||||
|
||||
+29
-3
@@ -69,7 +69,7 @@ def test_schema_creates_on_an_empty_file(tmp_path: Path) -> None:
|
||||
"application_events", "agents", "scores", "state"} <= tables
|
||||
assert "idx_roles_cluster" in indexes
|
||||
assert store.migrations_applied == []
|
||||
assert LATEST == 14
|
||||
assert LATEST == 15
|
||||
# A second open finds it current and applies nothing.
|
||||
assert Store(path).migrations_applied == []
|
||||
|
||||
@@ -88,10 +88,19 @@ def _columns(path: Path, table: str) -> list[tuple[str, str, int, str]]:
|
||||
return [(r[1], r[2], r[3], r[4]) for r in conn.execute(f"PRAGMA table_info({table})")]
|
||||
|
||||
|
||||
def _undo_v15(conn: sqlite3.Connection) -> None:
|
||||
"""A fresh file put back to the v14 shape: no Watchlist columns on a
|
||||
company."""
|
||||
conn.execute("ALTER TABLE companies DROP COLUMN watch")
|
||||
conn.execute("ALTER TABLE companies DROP COLUMN careers_opened_at")
|
||||
|
||||
|
||||
def _undo_v14(conn: sqlite3.Connection) -> None:
|
||||
"""A fresh file put back to the v13 shape: an agent's intent and its
|
||||
cached vector on the agent row, no prompts, no prompt on a score. Every
|
||||
downgrade below starts here, since v14 is the last migration."""
|
||||
downgrade below starts here, after `_undo_v15`, since v15 is the last
|
||||
migration."""
|
||||
_undo_v15(conn)
|
||||
conn.execute("DROP TABLE agent_prompts")
|
||||
conn.execute("ALTER TABLE scores DROP COLUMN prompt")
|
||||
conn.execute("ALTER TABLE agents ADD COLUMN intent TEXT NOT NULL DEFAULT ''")
|
||||
@@ -127,6 +136,23 @@ def test_a_v1_file_migrates_to_the_shape_a_new_file_has(tmp_path: Path) -> None:
|
||||
assert sorted(_columns(old, table)) == sorted(_columns(fresh, table))
|
||||
|
||||
|
||||
def test_a_v14_file_gains_the_watchlist_columns_and_leaves_companies_unrated(
|
||||
tmp_path: Path) -> None:
|
||||
path = tmp_path / "v14.db"
|
||||
Store(path).add_company("Acme", ats="teamtailor", country="DK", careers_url="https://a.example")
|
||||
with sqlite3.connect(path) as conn:
|
||||
_undo_v15(conn)
|
||||
conn.execute("PRAGMA user_version = 14")
|
||||
|
||||
migrated = Store(path)
|
||||
|
||||
assert migrated.migrations_applied == [15]
|
||||
acme = migrated.company("acme")
|
||||
assert acme is not None
|
||||
assert (acme.ats, acme.careers_url) == ("teamtailor", "https://a.example")
|
||||
assert (acme.watch, acme.careers_opened_at) == (None, "")
|
||||
|
||||
|
||||
def test_a_v8_file_gains_ats_slug_and_keeps_its_companies(tmp_path: Path) -> None:
|
||||
path = tmp_path / "v8.db"
|
||||
Store(path).add_company("Acme", ats="teamtailor", country="DK")
|
||||
@@ -325,7 +351,7 @@ def test_v14_makes_each_intent_the_agents_one_prompt_with_its_vector(tmp_path: P
|
||||
|
||||
migrated = Store(path)
|
||||
|
||||
assert migrated.migrations_applied == [14]
|
||||
assert migrated.migrations_applied == [14, 15]
|
||||
assert migrated.agent(backend.id).prompts == [ # type: ignore[union-attr]
|
||||
Prompt(name="Backend", text="python backend")]
|
||||
assert migrated.agent(blank.id).prompts == [] # type: ignore[union-attr]
|
||||
|
||||
+50
-2
@@ -430,7 +430,8 @@ def test_companies_lists_board_and_open_role_count(
|
||||
assert row == {"key": "acme", "name": "Acme", "board": "greenhouse",
|
||||
"subscription_id": sub.id, "on": True, "affinity": 0, "open_roles": 1,
|
||||
"ats": "greenhouse", "ats_slug": "", "careers_url": "",
|
||||
"country": "DK", "failing_since": "", "failing_reason": "",
|
||||
"country": "DK", "city": "", "domain": "", "watch": None,
|
||||
"careers_opened_at": "", "failing_since": "", "failing_reason": "",
|
||||
"from_search": False}
|
||||
[other] = [c for c in res.json() if c["key"] == "other"]
|
||||
assert (other["board"], other["subscription_id"], other["on"], other["ats"]) == (
|
||||
@@ -552,6 +553,53 @@ def test_post_score_answers_with_the_job_to_wait_for(client: TestClient, queue:
|
||||
assert queue.jobs.get(res.json()["id"]).kind == "score"
|
||||
|
||||
|
||||
# ------------------------------------------------------------- watchlist
|
||||
|
||||
def test_the_watchlist_rating_is_global_and_leaves_affinity_alone(
|
||||
client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme", ats="workday")
|
||||
agent = store.save_agent("A")
|
||||
store.set_affinity(agent.id, "acme", 1)
|
||||
|
||||
for watch, stored in ((True, 1), (False, 0), (None, None)):
|
||||
res = client.post("/api/companies/acme/watch", json={"watch": watch})
|
||||
assert res.status_code == 200 and res.json()["watch"] == stored
|
||||
listed = client.get("/api/companies").json()[0]
|
||||
assert (listed["watch"], listed["affinity"]) == (stored, 1)
|
||||
|
||||
|
||||
def test_the_careers_page_is_set_cleared_and_must_be_a_web_address(
|
||||
client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme")
|
||||
|
||||
res = client.post("/api/companies/acme/careers", json={"careers_url": "https://a.example/jobs"})
|
||||
assert res.status_code == 200 and res.json()["careers_url"] == "https://a.example/jobs"
|
||||
for bad in ("javascript:alert(1)", "a.example/jobs", "ftp://a.example"):
|
||||
assert client.post("/api/companies/acme/careers",
|
||||
json={"careers_url": bad}).status_code == 422
|
||||
assert store.company("acme").careers_url == "https://a.example/jobs"
|
||||
cleared = client.post("/api/companies/acme/careers", json={"careers_url": ""})
|
||||
assert cleared.status_code == 200 and store.company("acme").careers_url == ""
|
||||
|
||||
|
||||
def test_opening_the_careers_page_stamps_the_time(client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme")
|
||||
assert client.get("/api/companies").json()[0]["careers_opened_at"] == ""
|
||||
|
||||
res = client.post("/api/companies/acme/opened")
|
||||
|
||||
assert res.status_code == 200
|
||||
assert res.json()["careers_opened_at"] == store.company("acme").careers_opened_at != ""
|
||||
assert client.get("/api/companies").json()[0]["careers_opened_at"] != ""
|
||||
|
||||
|
||||
def test_the_watchlist_endpoints_404_for_an_unknown_company(client: TestClient) -> None:
|
||||
assert client.post("/api/companies/nope/watch", json={"watch": True}).status_code == 404
|
||||
assert client.post("/api/companies/nope/careers",
|
||||
json={"careers_url": "https://a.example"}).status_code == 404
|
||||
assert client.post("/api/companies/nope/opened").status_code == 404
|
||||
|
||||
|
||||
# ----------------------------------------------------------- applications
|
||||
|
||||
def test_save_creates_an_application_with_a_saved_event(
|
||||
@@ -629,7 +677,7 @@ def test_the_applications_page_has_no_next_column(client: TestClient) -> None:
|
||||
# -------------------------------------------------------------------- tabs
|
||||
|
||||
def test_every_page_renders_with_the_whole_nav(client: TestClient) -> None:
|
||||
assert [t.label for t in TABS] == ["Roles", "Applications"]
|
||||
assert [t.label for t in TABS] == ["Roles", "Applications", "Watchlist"]
|
||||
assert [t.label for t in SETTINGS] == ["Search agents", "Sources", "Account"]
|
||||
assert all(t.path.startswith("/settings/") for t in SETTINGS)
|
||||
for tab in (*TABS, *SETTINGS):
|
||||
|
||||
Reference in new issue
Block a user