From 699bf81e3b66ba325267eb814100333cc58293c8 Mon Sep 17 00:00:00 2001 From: Wolf Date: Wed, 30 Sep 2026 13:47:06 +0200 Subject: [PATCH] Fetch a role's posting text through fetch_posting, so a Jobindex role is read from its Se jobbet link Co-Authored-By: Claude Opus 5.5 --- app/web/api.py | 40 +++++++--------------------------------- 1 file changed, 7 insertions(+), 33 deletions(-) diff --git a/app/web/api.py b/app/web/api.py index edb764d..c71d3ea 100644 --- a/app/web/api.py +++ b/app/web/api.py @@ -21,7 +21,7 @@ from app.models import ( ) from app.storage import Store from app.web.deps import ConfigDep, StoreDep -from desk.tools import agent, scrape +from desk.tools import agent from pipeline import Job from pipeline.web import QueueDep @@ -351,21 +351,6 @@ def place_labels(tokens: list[str] = Query(default=[])) -> list[PlaceLabel]: # ------------------------------------------------- roles: text and summary -#: What the read page toasts when a posting page gave nothing readable, by -#: `desk.tools.failures` category. -_UNREADABLE = { - "timeout": "The posting page took too long to answer. Try again in a minute.", - "unreachable": "The posting page could not be reached.", - "rate_limited": "The posting site is refusing requests for now. Try again later.", - "server_error": "The posting site answered with an error. Try again later.", - "not_found": "The posting page is gone, so the role has probably closed.", - "denied": "The posting site refused to show the page.", - "consent_wall": "The posting page showed a consent banner instead of the posting.", - "js_required": "The posting page only renders in a browser. Open it with the link instead.", - "empty": "The posting page had no readable text on it.", -} - - def _known_role(store: Store, uid: str) -> Role: role = store.role(uid) if role is None: @@ -376,23 +361,12 @@ def _known_role(store: Store, uid: str) -> Role: @router.post("/roles/{uid}/text") def fetch_text(uid: str, store: StoreDep) -> Role: """Fetch the posting page once and keep it as plain text, for a role whose - description is a teaser. Synchronous: one request the person asked for, - and on demand rather than in the pull because each fetch of a Jobindex - redirect counts as a click in its statistics.""" - role = _known_role(store, uid) - if role.article_text: - raise HTTPException(409, "The posting text is already fetched.") - if not role.original_url: - raise HTTPException(422, "This role has no link to fetch the posting from.") - got = scrape.scrape(role.original_url) - text = got.content.plain_text.strip() if got.content is not None else "" - if not text: - raise HTTPException(422, _UNREADABLE.get( - got.failure, "Nothing readable came back from the posting page.")) - updated = store.set_article_text(uid, text) - if updated is None: - raise HTTPException(404, f"no such role: {uid}") - return updated + description is a teaser (`jobs.posting.fetch_posting`); a Jobindex role + is read from the page its "Se jobbet" link leads to.""" + try: + return jobs.posting.fetch_posting(store, uid) + except jobs.posting.PostingError as exc: + raise HTTPException(exc.status, str(exc)) from exc @router.post("/roles/{uid}/summarise", status_code=202)