Merge branch 'main' into wp1-byhand-api
# Conflicts: # app/models.py # app/storage/schema.py # app/storage/store.py # app/web/api.py # tests/test_storage.py # tests/test_web.py
This commit is contained in:
commit
1a2689e08d
17 files changed
+565
-109
No files matched your search
+74
-17
@@ -427,12 +427,12 @@ def test_companies_lists_board_and_open_role_count(
|
||||
res = client.get("/api/companies")
|
||||
assert res.status_code == 200
|
||||
[row] = [c for c in res.json() if c["key"] == "acme"]
|
||||
assert row == {"key": "acme", "name": "Acme", "domain": "", "notes": "",
|
||||
"board": "greenhouse", "subscription_id": sub.id, "on": True,
|
||||
"affinity": 0, "open_roles": 1, "ats": "greenhouse", "ats_slug": "",
|
||||
"careers_url": "", "country": "DK", "failing_since": "",
|
||||
"failing_reason": "", "from_search": False, "hand_reason": "",
|
||||
"checked_at": "", "by_hand": False}
|
||||
assert row == {"key": "acme", "name": "Acme", "notes": "", "board": "greenhouse",
|
||||
"subscription_id": sub.id, "on": True, "affinity": 0, "open_roles": 1,
|
||||
"ats": "greenhouse", "ats_slug": "", "careers_url": "",
|
||||
"country": "DK", "city": "", "domain": "", "watch": None,
|
||||
"careers_opened_at": "", "failing_since": "", "failing_reason": "",
|
||||
"from_search": False, "hand_reason": "", "by_hand": False}
|
||||
[other] = [c for c in res.json() if c["key"] == "other"]
|
||||
assert (other["board"], other["subscription_id"], other["on"], other["ats"]) == (
|
||||
"", None, None, "")
|
||||
@@ -555,6 +555,53 @@ def test_post_score_answers_with_the_job_to_wait_for(client: TestClient, queue:
|
||||
assert queue.jobs.get(res.json()["id"]).kind == "score"
|
||||
|
||||
|
||||
# ------------------------------------------------------------- watchlist
|
||||
|
||||
def test_the_watchlist_rating_is_global_and_leaves_affinity_alone(
|
||||
client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme", ats="workday")
|
||||
agent = store.save_agent("A")
|
||||
store.set_affinity(agent.id, "acme", 1)
|
||||
|
||||
for watch, stored in ((True, 1), (False, 0), (None, None)):
|
||||
res = client.post("/api/companies/acme/watch", json={"watch": watch})
|
||||
assert res.status_code == 200 and res.json()["watch"] == stored
|
||||
listed = client.get("/api/companies").json()[0]
|
||||
assert (listed["watch"], listed["affinity"]) == (stored, 1)
|
||||
|
||||
|
||||
def test_the_careers_page_is_set_cleared_and_must_be_a_web_address(
|
||||
client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme")
|
||||
|
||||
res = client.post("/api/companies/acme/careers", json={"careers_url": "https://a.example/jobs"})
|
||||
assert res.status_code == 200 and res.json()["careers_url"] == "https://a.example/jobs"
|
||||
for bad in ("javascript:alert(1)", "a.example/jobs", "ftp://a.example"):
|
||||
assert client.post("/api/companies/acme/careers",
|
||||
json={"careers_url": bad}).status_code == 422
|
||||
assert store.company("acme").careers_url == "https://a.example/jobs"
|
||||
cleared = client.post("/api/companies/acme/careers", json={"careers_url": ""})
|
||||
assert cleared.status_code == 200 and store.company("acme").careers_url == ""
|
||||
|
||||
|
||||
def test_opening_the_careers_page_stamps_the_time(client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme")
|
||||
assert client.get("/api/companies").json()[0]["careers_opened_at"] == ""
|
||||
|
||||
res = client.post("/api/companies/acme/opened")
|
||||
|
||||
assert res.status_code == 200
|
||||
assert res.json()["careers_opened_at"] == store.company("acme").careers_opened_at != ""
|
||||
assert client.get("/api/companies").json()[0]["careers_opened_at"] != ""
|
||||
|
||||
|
||||
def test_the_watchlist_endpoints_404_for_an_unknown_company(client: TestClient) -> None:
|
||||
assert client.post("/api/companies/nope/watch", json={"watch": True}).status_code == 404
|
||||
assert client.post("/api/companies/nope/careers",
|
||||
json={"careers_url": "https://a.example"}).status_code == 404
|
||||
assert client.post("/api/companies/nope/opened").status_code == 404
|
||||
|
||||
|
||||
# ----------------------------------------------------------- applications
|
||||
|
||||
def test_save_creates_an_application_with_a_saved_event(
|
||||
@@ -632,7 +679,7 @@ def test_the_applications_page_has_no_next_column(client: TestClient) -> None:
|
||||
# -------------------------------------------------------------------- tabs
|
||||
|
||||
def test_every_page_renders_with_the_whole_nav(client: TestClient) -> None:
|
||||
assert [t.label for t in TABS] == ["Roles", "Applications"]
|
||||
assert [t.label for t in TABS] == ["Roles", "Applications", "Watchlist"]
|
||||
assert [t.label for t in SETTINGS] == ["Search agents", "Sources", "Account"]
|
||||
assert all(t.path.startswith("/settings/") for t in SETTINGS)
|
||||
for tab in (*TABS, *SETTINGS):
|
||||
@@ -1231,8 +1278,9 @@ def test_a_company_is_added_by_hand_with_a_reason_and_a_link(
|
||||
"key": "revolut", "name": "Revolut Ltd", "domain": "", "notes": "wants a login",
|
||||
"board": "", "subscription_id": None, "on": None, "affinity": 0, "open_roles": 0,
|
||||
"ats": "", "ats_slug": "", "careers_url": "https://revolut.example/careers",
|
||||
"country": "", "failing_since": "", "failing_reason": "", "from_search": False,
|
||||
"hand_reason": "added", "checked_at": "", "by_hand": True}
|
||||
"country": "", "city": "", "watch": None, "careers_opened_at": "",
|
||||
"failing_since": "", "failing_reason": "", "from_search": False,
|
||||
"hand_reason": "added", "by_hand": True}
|
||||
assert store.company("revolut").hand_reason == "added" # type: ignore[union-attr]
|
||||
|
||||
other = client.post("/api/companies", json={"name": "Meta", "hand_reason": "blocked"})
|
||||
@@ -1316,17 +1364,26 @@ def test_a_company_with_a_board_keeps_its_name_and_takes_the_other_edits(
|
||||
assert store.company("acme").name == "Acme" # type: ignore[union-attr]
|
||||
|
||||
|
||||
def test_checking_a_company_stamps_now(client: TestClient, store: Store) -> None:
|
||||
def test_the_watchlists_careers_link_and_the_by_hand_edit_share_one_url_rule(
|
||||
client: TestClient, store: Store) -> None:
|
||||
store.add_company("Acme", key="acme")
|
||||
for bad in ("https://", "javascript:alert(1)"):
|
||||
posted = client.post("/api/companies/acme/careers", json={"careers_url": bad})
|
||||
patched = client.patch("/api/companies/acme", json={"careers_url": bad})
|
||||
assert posted.status_code == patched.status_code == 422
|
||||
assert posted.json() == patched.json()
|
||||
assert store.company("acme").careers_url == "" # type: ignore[union-attr]
|
||||
|
||||
|
||||
def test_opening_a_by_hand_company_shows_when_it_was_last_looked_at(
|
||||
client: TestClient, store: Store) -> None:
|
||||
clock = Clock()
|
||||
store.clock = clock
|
||||
store.add_company("Acme", key="acme", hand_reason="unread")
|
||||
res = client.post("/api/companies/acme/checked")
|
||||
assert res.status_code == 200
|
||||
assert res.json()["checked_at"] == "2026-09-23T09:00:00+00:00"
|
||||
clock.tick(48)
|
||||
assert client.post("/api/companies/acme/checked").json()["checked_at"] == (
|
||||
"2026-09-25T09:00:00+00:00")
|
||||
assert client.post("/api/companies/nope/checked").status_code == 404
|
||||
assert client.post("/api/companies/acme/opened").status_code == 200
|
||||
[row] = client.get("/api/companies").json()
|
||||
assert (row["by_hand"], row["careers_opened_at"]) == (True, "2026-09-23T09:00:00+00:00")
|
||||
assert client.post("/api/companies/acme/checked").status_code in (404, 405)
|
||||
|
||||
|
||||
def test_a_company_is_deleted_unless_it_is_read(
|
||||
|
||||
Reference in new issue
Block a user